patternfly / design-tokens

MIT License
1 stars 8 forks source link

feat(animation): add motion tokens #54

Closed srambach closed 4 months ago

srambach commented 4 months ago

Fixes #52

@mcoker @lboehling @kaylachumley Do you think the base tokens (like --pf-t--global--delay--400) should have "motion" in them?

@mcoker Is it ok to include these in the -default scss file?

mcoker commented 4 months ago

@mcoker @lboehling @kaylachumley Do you think the base tokens (like --pf-t--global--delay--400) should have "motion" in them?

@srambach I'm curious if others have an opinion. A little bit on what I'm thinking is...

Pros to not including --motion:

Pros to including --motion:

@mcoker Is it ok to include these in the -default scss file?

I don't see why not. Is there a potential issue you can think of? Is it a question of whether we need an additional token file (like -motion or something)?

srambach commented 4 months ago

Closing in favor of #56, which brings in the relevant tokens. As to naming... let's go with this for the moment. And motion tokens are included in the default scss token file.