feat(exporter): don't export figma-only variables

patternfly / design-tokens

MIT License

1 stars 8 forks source link

feat(exporter): don't export figma-only variables #65

Closed srambach closed 5 months ago

srambach commented 5 months ago

Fixes #61

This will ignore variables that include "figma-only" To test, use a branch of the tokens figma file that has figma-only files and run the exporter. Check that there are no tokens with "figma-only" in the name and that all others are still there.

srambach commented 5 months ago

After experimenting, it looks like the transform isn't matching global.font.weight.body.100 etc because it's a layer too deep. If I remove .body and .heading from it, it works ok. I see a few options:

figure out how to get style dictionary to handle that extra layer
remove the heading and body layers from global.font.weight in the base tokens. This would match how line-height is. I've tried this and it works.
change .global.font.weight.body.100 to .global.font-weight.body.100. This also seems to work but isn't quite the pattern we've been using I think.
@lboehling @mcoker

lboehling commented 5 months ago

i'd be fine renaming to font--weight--[100-400] and removing the body/heading in the base tokens.

srambach commented 5 months ago

i'd be fine renaming to font--weight--[100-400] and removing the body/heading in the base tokens.

Cool - ultimately we should probably understand why it doesn't handle it, but I think this particular change makes sense for the base tokens.

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: