chore(tokens): sort scss by name then by reference

evwilkin commented 5 months ago

Closes #17

This PR:

Sorts tokens by name alphabetically
Then sorts token by reference to ensure no var is referenced before it is declared

Though changes with referenced vars may be hard to predict the adjusted file outcome, this should limit variability in output scss files due to consistent alphabetical sorting, hopefully making the diffs between files smaller and more consistent as well.

Note: looking at tokens-default.scss as an example, the newly output file seems to be about 30 lines longer which is worth further investigation to confirm where these additional rules are coming from.

srambach commented 4 months ago

Let's remove the sort by reference, since CSS doesn't care about that, and it could introduce an inconsistency in the order.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.11.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

patternfly / design-tokens

chore(tokens): sort scss by name then by reference #69