patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
114 stars 104 forks source link

[new icon] processor #1210

Closed jgiardino closed 1 year ago

jgiardino commented 1 year ago

I'm working on a project where a user can create a processor for handling events coming in from a source before the event payload is routed to a sink (i.e. a target destination, like sending a slack message or running an ansible playbook).

@lboehling recently created icons that we can use for sources and sinks, so having a processor icon that is visually similar would be ideal: https://github.com/patternfly/patternfly/issues/5226

A processor can be simple or complex, but these are some of the things that could be defined in a processor:

yichen1yu commented 1 year ago

processor-icon-01 processor-icon-02 processor-icon-03

yichen1yu commented 1 year ago

Three options are provided above for feedback.

sbuenafe-rh commented 1 year ago

Thanks @yichen1yu!

Of the three options, the last option with the diamond shape resonated the most. I reminded me of a flow diagram and diamonds represented the decision point. Processors in Smart Events, I think act in this manner, filters and/or transforms the data and then moves it through the workflow. I'm also curious to see what it would look like with an arrowhead at the top, just to show that the filter or transformed data gets routed to a sink connector.

cc: @jgiardino

yichen1yu commented 1 year ago

processor-icon-04

yichen1yu commented 1 year ago

Here you go @sbuenafe-rh

jgiardino commented 1 year ago

Great suggestion, @sbuenafe-rh! I really like that latest option, @yichen1yu. I think the only final question I have is how does this look at smaller sizes? It looks good really big, but as it scales down, is the diamond appropriately sized? 🤷‍♀️ It's hard to judge that at this scale.

sbuenafe-rh commented 1 year ago

@yichen1yu Thank you! LGTM but reading @jgiardino's comment, it would be good to know how this icon scales?

yichen1yu commented 1 year ago

Just replied to Jenn on Slack, I think it still looks good when it's smaller. Tho the diamond shape in the middle tends to look like a circle when you shrink it really small, I enlarged the diamond shape to kinda mitigate it. Below is the icon in large PF size (24 px) and in medium PF size (18 px) @sbuenafe-rh @jgiardino processor-icon-large processor-icon-medium

jgiardino commented 1 year ago

Thanks for sharing the smaller examples. The copy/paste looks like it resulted a fuzzier example than what likely gets rendered via the actual icon, but I wanted to pass along screencaps of the related icons for source and sink.

It could just be that the example above is a bit fuzzy and the colors are different, but it might be good to check this icon against the existing icons to make sure the line thickness is the same.

image

yichen1yu commented 1 year ago

Thanks for sending over the screenshots! Do you know what size are sink and source icons on the screenshots? I am definitely export and same size of processor icon for comparison. I guess it could be the reason that I exported icons in the last comment in png format for convenience and png always looks a bit fuzzier than svg. When it comes to hand over, icons will be in svg format.

jgiardino commented 1 year ago

It looks like they are rendering at 21px wide in that example, but the classes applied also seem inconsistent with what I'm seeing on pf.org.

Here is an updated screencap where I used the PF icon examples to render the icon, so these should be properly showing at the md and lg sizes.

image
yichen1yu commented 1 year ago

Hey @jgiardino @sbuenafe-rh sorry for the delay here, just be back from f2f today. I'v checked with Michael Celedonia for how to export a more clear version of small size icon and he helped me slightly adjusted to make sure the straight lines are align with the grid. However, since this is png, it will still be a little bit fuzzy. But for the final output, just like the one you used in the screenshot, it will be svg, which will be clearer than png.

p.s I cannot upload svg since no matter the size of my export, it always auto size to your screen size.

Updated - processor-icon-16px Updated - processor-icon-24px

jgiardino commented 1 year ago

Thanks for the update, @yichen1yu! and thanks for working on this icon 😄