patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
115 stars 105 forks source link

Color variant of the spinner when on backdrop #1220

Closed Misjohns closed 1 year ago

Misjohns commented 1 year ago

Requesting new features, enhancements, or design changes to PatternFly

Enhancement to the existing backdrop with spinner pattern. The current implementation uses a #0066C spinner on a #030303, .62 backdrop. The contrast ratio is only 1.07:1, WCAG 2.1 requires a contrast ratio of at least 3:1 for graphics and user interface components. There is no support to customize either the spinner or the backdrop. Providing a variant for the spinner when placed over the backdrop would help with the accessibility of this component.

Current component (#0066CC spinner):

Screen Shot 2022-10-06 at 4 23 24 PM

Recommendation (#73BCF7 spinner):

Screen Shot 2022-10-06 at 4 26 09 PM
nicolethoen commented 1 year ago
mcarrano commented 1 year ago

Per discussions with @mcoker and @thatblindgeye it was decided that placing the spinner directly on a background like this is problematic and the the spinner should always be placed within a container. Transferring this back to design for more consideration about the best way to handle this use case.