patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
115 stars 105 forks source link

let users know that a primary tab has some secondary tabs that contain additional related information #1224

Open yfrimanm opened 1 year ago

yfrimanm commented 1 year ago

Requesting new features, enhancements, or design changes to PatternFly

Currently Primary tabs which have nested secondary tabs are not marked as such. I was thinking that it may be beneficial to users to know which primary tab contains several more secondary tabs, so they can look over there when searching for specific info.

This can be a simple solution if we can add a caret icon next to the tab name to indicate that there are more nested tabs below that primary tab. TABS caret icon

Please view the detailed explanation and mockups here: [https://docs.google.com/document/d/1zokCPRft9Pt9QSZSCNNk9hgPp2coMgzTy9cfIoGYQTA/edit?usp=sharing]

Thank you.

mcarrano commented 1 year ago

@yfrimanm thanks for submitting this request. We probably would not use the caret as you suggest since we already use that for a optional tab overflow affordance. See below.

Image

I do however, see the value of some visual indication that a tab has sub tabs. I invite you to put this on the agenda for a future PatternFly design share meeting as we can have more discussion.

yfrimanm commented 1 year ago

Thanks @mcarrano, will do.

yfrimanm commented 1 year ago

Alternative options to the caret icon can be:

  1. angle down icon TABS angle down icon
  2. horizontal ellipsis icon TABS horizontal ellipsis
  3. The secondary tabs are shown on hover state (like a flyout) TABS secondary tabs show on hover state like a flyout
yfrimanm commented 1 year ago
  1. angle up+angle down icon TABS angle up+down
JustinXHale commented 1 year ago

@yfrimanm thanks for submitting this request. We probably would not use the caret as you suggest since we already use that for a optional tab overflow affordance. See below.

Image

I do however, see the value of some visual indication that a tab has sub tabs. I invite you to put this on the agenda for a future PatternFly design share meeting as we can have more discussion.

@mcarrano I understand that we use the caret icon bc we use it for tab overflow, but why cant the same icon complete similar actions? The same icon is used an accordion menu, such as the one in the left nav.

mcarrano commented 1 year ago

Yes, that's true @JustinXHale . But I'd worry if we are using the same Icon for different behaviors within the tab bar.

JustinXHale commented 1 year ago

@mcarrano Understand. I guess it depends on how we look at it. The caret could mean view drop down (as used in left nav and overflow menu), but I think we could also read it as view more or expand which would make sense for all 3 cases.

yfrimanm commented 1 year ago

Hi, I've updated the doc with a couple of more options. I can share them in the next call to gather more feedback. Thank you.

yfrimanm commented 1 year ago

@mcarrano we are making a progress with the double chevron down option #4, because we would like to include it for the upcoming release. Do we know if this can get implemented as a PF component somewhere in the near future? Thanks.

mcarrano commented 1 year ago

@yfrimanm Right now the team is heads down on the PatternFly 5 release through June. The earliest we would be able to get this in will be Q3. If you feel in a good place with the design proposal for this, I'd suggest getting it on the agenda for an upcoming PF design share meeting where it can be reviewed by the larger design community.

mcarrano commented 1 year ago

Any updates on this @yfrimanm ?

yfrimanm commented 1 year ago

@mcarrano unfortunately no. The "temporary" implementation that was created internally, wasn't satisfying enough. As for now, we are waiting the PF team to handle this component enhancement.