patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
115 stars 105 forks source link

Popover Triggered by Mousehover #1235

Closed heyethankim closed 1 year ago

heyethankim commented 1 year ago

Requesting new features, enhancements, or design changes to PatternFly

PatternFly has Tooltip and popover.

If the information is short, use tooltip, which is triggered by mouse hover. If it is long, use popover, which is triggered by a click.

In ACM Governance, we need two different interactions for a hyperlink.

On click, it links to a detail page. On hover, it triggers a popover with a long description of a policy.

image

Try the prototype: https://marvelapp.com/prototype/68dcjba/screen/90255658

There could be thousands of policies like Verizon but we don't control the policy names, which are not always easy to understand. So users should be able to scan through what individual policies are about.

We may utilize the current tooltip definition, which is rendered as white text on the black background, but it should be able to be triggered for a link.

mcarrano commented 1 year ago

@heyethankim why can't you use a Tooltip here? Seems like that would give you the interaction that you want. The problem with triggering a popover on hover is that they require the user to tack an action to close them, which I don't think is what you want.

heyethankim commented 1 year ago

Right! As I said, we could definitely utilize the current tooltip definition. Since this kind of behavior was not documented (a tooltip from a hyperlink) in the page, I wanted to address it.

Could we add this in the page?

mcarrano commented 1 year ago

By page, do you mean update the design guideline? Sure, that's easy enough to do. @heyethankim would you be interested in contributing that? @mmenestr can help you get started.

heyethankim commented 1 year ago

Yes. I would love to do that. Thanks, @mcarrano. @mmenestr, Could you guide me?

mmenestr commented 1 year ago

Created this docs issue and slacked Ethan to discuss!

mcarrano commented 1 year ago

Closing in favor of the Org issue referenced above.