search

patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
114 stars 104 forks source link

Define "Tile" variant of the Card component #1244

Closed mcarrano closed 1 year ago

mcarrano commented 1 year ago

Cards and Tiles appear to be redundant as tiles are really just more specific versions of a clickable card. To simplify this, we should deprecate the Tile component in favor of a card variant that embodies all the same properties. Specifically, tiles need to be compact, clickable, and retain state. They should not be selectable or contain embedded actions.

Need to define what a tile variant of the card should look like so examples can be added to the Card component. See https://www.patternfly.org/v4/components/tile for existing tiles and also https://github.com/patternfly/patternfly/issues/5267 which identifies some enhancements to the Tile component for more information.

mcarrano commented 1 year ago

@yichen1yu please be sure to keep @pankajshivpuje and @tiyiprh in the loop on this to make sure that we new tile variant you are defining follows similar patterns as clickable cards. @tiyiprh can you add a link to your designs here?

Ultimately I see tiles as just compact versions of clickable cards that have all the same afforances and behaviors. Let me know if there are any questions.

yichen1yu commented 1 year ago

@mcarrano Sure I will. Tina has reached out to me to offer help earlier. I will keep both of them in loop for this ticket.

tiyiprh commented 1 year ago

Here is the link to the Sketch file!

yichen1yu commented 1 year ago

Here is the documentation of how new card variants, clickable card and single selectable card, can fulfill the current behaviors and variations of tile component. Here is the link to the Sketch file that demonstrates it with examples

mcarrano commented 1 year ago

@yichen1yu I reviewed your documentation and left a couple of comments. But otherwise this is looking good. @mceledonia @andrew-ronaldson can you also take a look? I believe that based on an earlier issue, we wanted left aligned tiles also for better alignment with other Red Hat design systems. @mceledonia can you confirm? Thanks.

andrew-ronaldson commented 1 year ago

Designs and docs look good. This is a lead up to this core issue https://github.com/patternfly/patternfly/issues/5325