patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
114 stars 105 forks source link

Bug - Button - loading spinner hard to see #1289

Open jschuler opened 6 months ago

jschuler commented 6 months ago

Describe the problem When the button is both disabled and in loading state, the loading spinner is hard to see. See comparison PF4 and PF5.

How do you reproduce the problem?

<Button variant="secondary" isLoading isDisabled>Secondary</Button>

PF4 https://github.com/patternfly/patternfly-react/assets/869106/f27800b7-0dfd-4fdf-a4f2-71986f283251

PF5 https://github.com/patternfly/patternfly-react/assets/869106/90dbd1d7-78ef-402d-ab8d-5c1a3489211a

What is your environment?

What is your product and what release date are you targeting? OCM

Any other information?

tlabaj commented 5 months ago

cc @andrew-ronaldson @mcoker