search

patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
114 stars 105 forks source link

Table: revisit/verify mobile views for Penta #1290

Closed srambach closed 2 months ago

srambach commented 6 months ago 
          Currently we have this 8px border at narrow widths, but it's a lighter color (#f0f0f0) than when the border is only 1px thick. @andrew-ronaldson is this good for now or should we use a lighter gray for when the line is thick?

_Originally posted by @srambach in https://github.com/patternfly/patternfly/pull/6130#discussion_r1431513750_

One instance noted above, but in general we should verify the mobile behavior and check it with design.

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

kmcfaul commented 3 months ago

Moving DataList verification to a separate issue patternfly/patternfly-design#1291

kaylachumley commented 2 months ago

@srambach same change for datalist! default border color is good. It looks like the border width is fine on mobile now. I did notice a bug with the expandable row from desktop to mobile but i think that needs to be put on a different issue. I don't see an issue for that already so I'll ping the pf-scrum channel to make note of it

srambach commented 2 months ago

Core issue: https://github.com/patternfly/patternfly/issues/6556

andrew-ronaldson commented 2 months ago

Closing with core issue https://github.com/patternfly/patternfly/issues/6556