search

patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
114 stars 104 forks source link

DataList: revisit/verify mobile views for Penta #1291

Closed kmcfaul closed 5 months ago

kmcfaul commented 6 months ago

DataList verification issue counterpart (Table has a similar issue patternfly/patternfly-design#1290)

          Currently we have this 8px border at narrow widths, but it's a lighter color (#f0f0f0) than when the border is only 1px thick. @andrew-ronaldson is this good for now or should we use a lighter gray for when the line is thick?

_Originally posted by @srambach in https://github.com/patternfly/patternfly/pull/6130#discussion_r1431513750_

One instance noted above, but in general we should verify the mobile behavior and check it with design.

kaylachumley commented 5 months ago

@srambach Can we change the border width on mobile to be border-width: 2px (global/border/width/200)? The 8px border is bit thick. The default border color is fine. especially since it's not as thick anymore. Everything else looks good.

srambach commented 5 months ago

Yeah, no problem. Core issue https://github.com/patternfly/patternfly/issues/6555

andrew-ronaldson commented 5 months ago

Closing with this Core issue https://github.com/patternfly/patternfly/issues/6555