patternfly / patternfly-design

Use this repo to file all new feature or design change requests for the PatternFly project
114 stars 104 forks source link

Rethink styles used for slider ticks/tracks and progress bar tracks #1316

Closed lboehling closed 1 week ago

lboehling commented 1 month ago

The tokens we use in v6 for our sliders and progress bars work well for the light themes but don't translate well to the dark themes. The slider/progress tracks don't have enough contrast with the dark brand token value, and the slider tick marks in the dark theme don't show against the track color. Need to either use different existing tokens here or create new tokens.

Sliders:

Screenshot 2024-07-08 at 10 41 39 AM Screenshot 2024-07-08 at 10 41 35 AM Screenshot 2024-07-08 at 10 41 50 AM Screenshot 2024-07-08 at 10 41 55 AM

Progress bars:

Screenshot 2024-07-08 at 10 45 06 AM Screenshot 2024-07-08 at 10 45 14 AM
lboehling commented 1 week ago

I see a couple different solutions for this:

First option would be:

-Base token updates:

-Progress bar: (No changes in core needed, would be handled at token level with the adjustments above)

image

-Slider:

image image

OR second option:

Possibly consider adding in new tokens for track/tick bkg color that would be used across slider/progress components. this would require more updates in core to both progress and slider components once made. --global--color--track--unfilled--default --global--color--track--filled--brand --global--color--track--filled--warning --global--color--track--filled--danger --global--color--track--filled--success --global--icon--color--tick--unfilled--default --global--icon--color--tick--filled--on-brand --global--icon--color--tick--filled--on-warning --global--icon--color--tick--filled--on-danger --global--icon--color--tick--filled--on-success

lboehling commented 1 week ago

After reviewing with @andrew-ronaldson and @mcoker, we decided to go with option 1. Tokens and components have been updated in Figma! Opening a follow up issue in core.