Closed serenamarie125 closed 6 years ago
Let's consider this part of a new pattern that concerns "Actions" whether they occur in a toolbar, listview, or other.
Should consider whether tooltip should be a standard element of the menu component or is this a new design pattern that specifies use of actions?
@cshinn had done some earlier work on Actions that was never published to the PatternFly website. See https://docs.google.com/document/d/1zDF8JoT9oDBr__KGS4uBE5X9VkMfxlFG5tPqSc1P6UU/edit?usp=sharing
I think that this provides a good starting point for documenting Actions as a new pattern and would be the right place to address the tooltip issue. This pattern could be generalized to make it clear that the Actions bar can exist within a toolbar, a list entry, or a card with corresponding examples.
@serenamarie125 @catrobson @maryclarke @jeperry thoughts?
Agree this is the right place. i think this is a very obvious thing to have a high level pattern for and would be much appreciated.
+1. @mcarrano can we all review Chris' doc, and then I'll create a OSUX story for him to formally contribute Actions to PF?
Yes, let's do that. If you haven't already done so, please take a few minutes to review the Google doc (it's short!) and feel free to comment. We can move forward from there.
@catrobson @maryclarke can you review Chris' doc (see above) and let us know if you are good to proceed with adding Actions as a new pattern?
@mcarrano I'm working on bringing that doc in line with more current patterns (its about three years old at this point) but I should have a PR up in the next couple days to check out. I'll also take any feedback on that document into account with the rewrite.
I've run across an interesting challenge with respect to the tooltip. Because the more actions kebab is often close to the edge of the screen, any tooltip above it will get cut off.
A tooltip to the side will have to overlap other parts of the toolbar, which doesn't look very good.
Thoughts?
I know that we could have the caret off to one side, but I believe that would require a special implementation just for this
Hmmm... So are you saying that our tooltips won't adjust when they intersect with the window boundary? @andresgalante thoughts about this?
@mcarrano they can adjust, but as far as I know, you'd end up with something like the second image, which seems sub-optimal
@cshinn can you please address #593 and #594 as part of this work?
This is an enhancement to the Kebab Menu documentation.
To aide with learnability, a "More Actions" tooltip should be available on the Kebab Menu.