search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
377 stars 91 forks source link

[feat] pfe-modal | add ability to give pfe-modal a dark background #1153

Open mwcz opened 3 years ago

mwcz commented 3 years ago

I'm attempting to make a barebones dark theme for arcade.redhat.com, and pfe-modal is presenting a small obstacle. pfe-modal's background is colored with --pfe-theme--color--surface--lightest and it feels wrong to set that to a dark color. Easy to work around, but the name of the background variable could be more abstract.

starryeyez024 commented 3 years ago

This is tangentially related to issue https://github.com/patternfly/patternfly-elements/issues/1090.

Per this comment:

it feels wrong to set [--pfe-theme--color--surface--lightest] to a dark color

probably it should have a local variable like --pfe-modal__content--BackgroundColor.