search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
377 stars 92 forks source link

[fix] pfe-band | max-width: auto which isn't valid #1693

Open wesruv opened 3 years ago

wesruv commented 3 years ago

Description of the issue

The width variable is also being used for max-width, see: https://github.com/patternfly/patternfly-elements/blob/9a96daae5568d21faa481538d821ceac8d50143c/elements/pfe-band/src/pfe-band.scss#L49

And here: https://github.com/patternfly/patternfly-elements/blob/9a96daae5568d21faa481538d821ceac8d50143c/elements/pfe-band/src/pfe-band.scss#L189

Impacted component(s)

Expected behavior

I don't know what the expected behavior is, hoping someone else does.

castastrophe commented 3 years ago

I'm wondering if this needs to be max-width: unset instead since I believe the goal is to unset the limits on the width at the mobile breakpoint. 🤔