search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
377 stars 92 forks source link

tools: static version property not set correctly #1885

Open bennypowers opened 2 years ago

bennypowers commented 2 years ago

Description of the issue

pfe-tools' packageVersion esbuild plugin reads the package.json version and interpolates it into each component's source code. The problem is that this appears to happen before the npm version command which actually updates the package.json version. 👀 👉 see chat thread, this may only be an issue for docs

Impacted component(s)

Steps to reproduce

  1. publish a package version

Expected behavior

el.constructor.version should match the package.json version

bennypowers commented 2 years ago

h/t @zeroedin for the report