search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 89 forks source link

feat(tools): parameterize react wrapper generator #2650

Closed bennypowers closed 7 months ago

bennypowers commented 7 months ago

Closes #2649

What I did

  1. parameterize react wrapper gen

Testing Instructions

  1. build react wrappers and compare output to main
  2. see rhds pr
changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: 8fb3588d9c41a748a8369d98e177d888b7220d9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @patternfly/pfe-tools | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 7 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit ac86fd9775a6d7f38e5cbf0fd8b3c7cbc98bbd82
Deploy Preview https://deploy-preview-2650--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

bennypowers commented 7 months ago

solution:

  1. process all ce exports in each module, rather than just the first
  2. use the class declaration name property for class name, not the ce export's nameaaaa