search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 89 forks source link

chip: button sizes should be WCAG 2.2 2.5.8 AA compliant #2662

Closed nikkimk closed 5 months ago

nikkimk commented 5 months ago

Description of the issue

Button sizes on chip and chip group should be a 24px minimum, or WCAG 2.2 2.5.8 AA compliant.

Impacted component(s)

Steps to reproduce

  1. Go to chip documentation
  2. Inspect the the close button on a chip.
  3. Inspect the the close button on a chip group.
  4. Inspect the the overflow button on a chip group.

Expected behavior

Minimum width and height should be 24px.

bennypowers commented 5 months ago

we can't solve this here, as we are beholden to upstream's design choices

we can file an issue on patternfly, but we have to ship this as is.