search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 89 forks source link

dropdown: disabled dropdown should still be focusable and reveal options #2669

Closed nikkimk closed 3 months ago

nikkimk commented 5 months ago

Description of the issue

WAI-ARIA recommends elements of a larger composite widget remain focusable.

Impacted component(s)

Steps to reproduce

  1. Go to Dropdown documentation -> Disabled dropdown
  2. Try to tab to the dropdown and open it.

Expected behavior

A disabled dropdown should still open but have all options disabled.

bennypowers commented 5 months ago

the disabled dropdown at http://v4-archive.patternfly.org/v4/components/dropdown#disabled-toggles is not focusable. we can't diverge from upstream. a11y issues on patternfly should be filed there.

bennypowers commented 3 months ago

the disabled dropdown at http://v4-archive.patternfly.org/v4/components/dropdown#disabled-toggles is not focusable. we can't diverge from upstream. a11y issues on patternfly should be filed there.

As discussed in chat, Nikki verified with pf team that her solution should be adopted upstream