search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 89 forks source link

fix(core): decouple listbox controller from DOM #2672

Closed bennypowers closed 3 months ago

bennypowers commented 5 months ago

What I did

  1. removed the dispatchEvent calls from listbox controller
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 6098be76dbe5d15dff55a8b97294e4f88283dc92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 5 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 7a0cb7d24b3a137caab303e18678c02ead28f02d
Deploy Preview https://deploy-preview-2672--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

nikkimk commented 3 months ago

This is not working with a keyboard.

@bennypowers where are we at with this one?

bennypowers commented 3 months ago

I think the goals of this pr were accomplished elsewhere. closing