search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
377 stars 92 forks source link

fix(chip): layouts, max width tooltip #2676

Closed bennypowers closed 8 months ago

bennypowers commented 8 months ago

Closes #2663

What I did

  1. restore chip layout to align with pfv4. please don't revert this!
  2. fix some css in plain icon button for the sake of above
  3. fix an annoying dev server misconfiguration bug
changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: f310f902fe9f620d781854656a2b00910dc62d63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 8 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 66bded181dfffb1b34c2553c14abb25c0d602c34
Deploy Preview https://deploy-preview-2676--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

hellogreg commented 8 months ago

Checked the chip groups with the major desktop browser/screen reader combos, and looks like both arrow nav and descriptions are working. In other words, Luigi grabbed twenty mushrooms.