fix(tabs)!: tabscontroller refactor

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.

https://patternflyelements.org/

MIT License

375 stars 85 forks source link

fix(tabs)!: tabscontroller refactor #2699

Closed bennypowers closed 4 months ago

bennypowers commented 4 months ago

Closes #2695

What I did

Total separation between RTIC and tabs state. Disabled tabs are still able to be focused via RTIC, just that they can't change the Tab's active tab state.

Remove most of tabscontroller's logic in favour of context, rtic.

Rename TabsController > TabsAriaController. It still has some helper functions. WDYT, @zeroedin?
PfTabs(host) - context for active index, cascading stuff like variant, box etc
PfTab(host) - updates own template accd to context. to avoid breaking css selectors, maybe reflect those context props for now. at least investigate it before removing the attrs on the host.

Testing Instructions

units, usability testing

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 0d19f9963a85de9d2b9e847aeeccebf42bbd0f5e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 4 months ago

Deploy Preview for patternfly-elements ready!

Name	Link
Latest commit	d9bcbb8bac09df0befd51d268c3be56b38671047
Deploy Preview	https://deploy-preview-2699--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

zeroedin commented 4 months ago

Should we now say that if <pf-tab aria-disabled="true"> is set that this has the same function as <pf-tab disabled> and update the component accordingly? /cc @nikkimk

Right now the component becomes selectable.