Closed zeroedin closed 3 months ago
Latest commit: 12a308fea6ef68887045317a73b3c7d3eb38f3bb
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 0bfeb3b2909cb2621a23263f4901b998755451d2 |
Deploy Preview | https://deploy-preview-2702--patternfly-elements.netlify.app/ |
To edit notification comments on pull requests, go to your Netlify site settings.
So, here's the current a11y state of the switch at patternflyelements.org (PFE) and in the deploy preview (DP). It's kind of a pick-your-poison with them.
TLDR:
Also wanted to mention that the DP version is better than PFE in Mac/iOS Safari because of some updates @zeroedin made yesterday. If needed (as in, if we're not yet ready to go with this new version of switch), maybe those same fixes could be made to the live PFE version, too--fixing the label issue, the page scroll issue, and hiding the SVG from assistive tech.
Looks like it could be getting a little closer, but still has issues.
Still works fine in Safari/VO.
This should get a major changeset because the label API changed, no? unless i'm mistaken and we already did that
You are correct we changed the label API by adding the <span>
instead of multiple labels. This should get a major.
@nikkimk or @hellogreg if we could get a final sign off please
What I did
InternalsController
<label>
with children having thedata-state
Testing Instructions
Notes to Reviewers
1.