search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

docs: v3 in dropdown #2704

Closed bennypowers closed 3 months ago

bennypowers commented 4 months ago

What I did

  1. adds v3 to the versions dropdown
  2. replaces <select> with <pf-dropdown>

Notes to Reviewers

  1. relies on #2703
changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 9a6c51ea55a9dc1b7c05baab084b536890d2cdc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 4 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit e0d92f6d547eea2babf44bcb2c8899d7dfcbed6c
Deploy Preview https://deploy-preview-2704--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

zeroedin commented 3 months ago

EDIT: Helps if I read notes to reviewers 🙈 Sorry for the ping ;)

Should pf-button in pf-dropdown have a <slot name="button-text"></slot> instead of the word Dropdown hard coded? /cc @nikkimk

https://github.com/patternfly/patternfly-elements/blob/d4e5411959d653a03e9aceb5dfaa913d30cfd317/elements/pf-dropdown/pf-dropdown.ts#L87-L96

bennypowers commented 3 months ago

EDIT: Helps if I read notes to reviewers 🙈 Sorry for the ping ;)

Should pf-button in pf-dropdown have a <slot name="button-text"></slot> instead of the word Dropdown hard coded? /cc @nikkimk

https://github.com/patternfly/patternfly-elements/blob/d4e5411959d653a03e9aceb5dfaa913d30cfd317/elements/pf-dropdown/pf-dropdown.ts#L87-L96

2703

nikkimk commented 3 months ago

EDIT: Helps if I read notes to reviewers 🙈 Sorry for the ping ;) Should pf-button in pf-dropdown have a <slot name="button-text"></slot> instead of the word Dropdown hard coded? /cc @nikkimk https://github.com/patternfly/patternfly-elements/blob/d4e5411959d653a03e9aceb5dfaa913d30cfd317/elements/pf-dropdown/pf-dropdown.ts#L87-L96

2703

Yes.