search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(button)!: remove shadow <button> #2707

Closed bennypowers closed 3 months ago

bennypowers commented 3 months ago

What I did

  1. remove the shadow <button> from pf-button
  2. implement (hopefully all of the) button semantics on the host
  3. refactor styles and whatnot to suit
  4. refactor pf-chip in response to button changes

Testing Instructions

  1. units, manual UX and SR testing on button and chip demos
  2. manual testing on form control demos (requestSubmit should call)

Notes to Reviewers

  1. I used css nesting, we might need to go back later and compile that out
  2. IMPORTANT: test failures on dropdown should be addressed in #2703 see https://github.com/patternfly/patternfly-elements/pull/2707#issuecomment-2007278323
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: f1ee6ff6c7c0c149edabd2da5ca30df2372050e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/elements | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit f1ee6ff6c7c0c149edabd2da5ca30df2372050e9
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/65f99f7dd5037c00087b7661
Deploy Preview https://deploy-preview-2707--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bennypowers commented 3 months ago

Failure on dropdown is likely related to https://github.com/dequelabs/axe-core/issues/4259

If manual UX testing passes, I suggest we exclude this assertion and leave a comment with a link to that issue

bennypowers commented 3 months ago

You could write a book with your lagtam's, Nikki