search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

`<pf-chip-group>`: overflow or close button are inaccessible by keyboard #2708

Closed nikkimk closed 3 months ago

nikkimk commented 3 months ago

Description of the issue

Using only a keyboard, the overflow and close buttons cannot be focused and clicked.

Impacted component(s)

Steps to reproduce

  1. In docs, go to Chip group with removable categories
  2. Use Tab to set focus on first chip in a chip group.
  3. Attempt to use right arrow key → to navigate to "1 more" overflow button.
  4. Attempt to use right arrow key → to navigate to close button.
  5. Neither button can be accessed via roving tabindex.

Expected behavior

Both the overflow or close buttons should be accessible via roving tabindex.

bennypowers commented 3 months ago

If this fixed in #2707 ?

nikkimk commented 3 months ago

If this fixed in #2707 ?

No. While reviewing #2707 I found the issue.

bennypowers commented 3 months ago

Closed by #2709