search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(chip): fixed `<pf-chip-group>` keyboard accessibility #2709

Closed nikkimk closed 3 months ago

nikkimk commented 3 months ago

What I did

  1. Ensured that roving tabindex is updated when <pf-chip-group> buttons are added.

Testing Instructions

  1. In DP, go to Chip group with removable categories
  2. Use Tab to set focus on first chip in a chip group.
  3. Use right arrow key → to navigate to "1 more" overflow button.
  4. Use right arrow key → to navigate to close button.
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 693edf2b14acde3791783255bffd7e7a6fbfeccf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/elements | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 693edf2b14acde3791783255bffd7e7a6fbfeccf
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/65fa701f94cdd200090a11b3
Deploy Preview https://deploy-preview-2709--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.