patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(button): use :active pseudo #2711

Closed bennypowers closed 3 months ago

bennypowers commented 3 months ago

What I did

  1. remove the active shadow class and use the host pseudo :active instead

Testing Instructions

  1. add this tokens to the dp demo and test clicking and dragging the button.
    pf-button { --pf-c-button--m-primary--active--BackgroundColor: limegreen; }
  2. when clicking the button, active state should persist as long as the mouse is down
  3. when mousing down, then dragging out of the button: active state should persist as long as the mouse is down, even if it leaves the browser viewport.

NOTE: DP demo will not work at all until #2710 is merged

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 881f15090795c0ab4abd532623d5b9618f542911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 531015d3f2ce3e9b2a4be45529004777a5d735cd
Deploy Preview https://deploy-preview-2711--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 881f15090795c0ab4abd532623d5b9618f542911
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/65fbcee9a57bbf000809f789
Deploy Preview https://deploy-preview-2711--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.