patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(button): prevent default behavior for spacebar #2716

Closed nikkimk closed 3 months ago

nikkimk commented 3 months ago

What I did

  1. Prevented default behavior on spacebar keydown

Testing Instructions

  1. Go to Button docs on DP
  2. Press Tab to navigate to any button.
  3. Press spacebar.
  4. Browser window scrolls.
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: dbf63ff918007e25670feab3200b6625481b0f57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 8f23b8f1eee560ec9a4c3614e4dd072c64b4d4f3
Deploy Preview https://deploy-preview-2716--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit dbf63ff918007e25670feab3200b6625481b0f57
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/65fc84ed6755db000858470e
Deploy Preview https://deploy-preview-2716--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.