patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(core)!: deprecate cascades decorator #2729

Closed bennypowers closed 3 months ago

bennypowers commented 3 months ago

Lit context provides us with an easier to manage and more robust alternative to the imperative cascades system, let's migrate to that and remove this in PFE 4

What I did

  1. mark @cascades and CascadeController as deprecated

Notes to reviewers:

RHDS uses @cascades in one file:

❯ rg cascades
elements/rh-tabs/rh-tabs.ts
8:import { cascades, deprecation } from '@patternfly/pfe-core/decorators.js';
140:  @cascades('rh-tab')
150:  @cascades('rh-tab', 'rh-tab-panel')
156:  @cascades('rh-tab', 'rh-tab-panel')

which we will remove when we update to TabsController, following PFE 3 release

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: f6ebd9f0c174217cd17c5cd70d1de8897ce18e3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | -------------------- | ----- | | @patternfly/pfe-core | Major | | @patternfly/elements | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bennypowers commented 3 months ago

@Arathy-s does cp elements use this?

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit f6ebd9f0c174217cd17c5cd70d1de8897ce18e3e
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/660461d83689fb00085f9c3e
Deploy Preview https://deploy-preview-2729--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.