search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(popover): prevent scrollbar #2730

Closed bennypowers closed 3 months ago

bennypowers commented 3 months ago

What I did

  1. hide the dialog before the popover animates open and after it animates closed
  2. Add a demo to illustrate the solution

Testing Instructions

  1. https://deploy-preview-2730--patternfly-elements.netlify.app/components/popover/demo/edge-of-viewport/ and set the viewport width so that the popover is at the far edge. For me, that was 1190 pixels wide.
  2. Observe that there is not horizontal scrollbar
  3. confirm that opening and closing the popover in various ways works as expected
  4. repeat step 3 for the other demo files

Notes to Reviewers

  1. Closes #2648
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 52e95360937c511c5ce60e172f009a67f838154d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/elements | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 52e95360937c511c5ce60e172f009a67f838154d
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/66056e665d18280008bd920c
Deploy Preview https://deploy-preview-2730--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Arathy-s commented 3 months ago

Tested locally as mentioned in the testing instructions. The horizontal scroll bar issue is now resolved.