patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(tabs): roles in sr #2731

Closed bennypowers closed 3 months ago

bennypowers commented 3 months ago

What I did

  1. apply role to tab and tab-panel elements directly, via TabsAriaController

Testing Instructions

  1. Closes #2692, see lighthouse results there
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 918bc0fc7c30ff25d03c43e4a33227dcd5569e3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/elements | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit ba23667b3373b062a41824afce48a513ea93f07b
Deploy Preview https://deploy-preview-2731--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.