search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(tools): dev server icon and colours #2733

Closed bennypowers closed 2 months ago

bennypowers commented 3 months ago

What I did

  1. change dev server header colour to black
  2. use correct url for dev server header icon
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 0cf74b65efe80d3f9af2eefc49fabf1d6c138760

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @patternfly/pfe-tools | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit f17f672c648a5d6eab0252b5e1ed0b96a5e8bba1
Deploy Preview https://deploy-preview-2733--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

bennypowers commented 2 months ago

@zeroedin please do

zeroedin commented 2 months ago

unexpected test failures. taking a look.

Update:

@bennypowers I pushed a fix for the failing pf-card test PTAL, working with Nikki to fix the pf-chip-group failing test. element.focus() SHOULD focus the first chip but doesn't seem to do that in this test.

Doing the following:

const firstChip = element.querySelector('pf-chip')!;
firstChip.focus();

works, but I don't think we should have to do this, the first chip should become focusable via RTIC IIRC and that's where the focus should land given delegatesFocus?

Either way if you feel like poking at it please do otherwise will return back to it in the morning.