patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(tools): typescript error resolution #2736

Closed bennypowers closed 2 months ago

bennypowers commented 3 months ago

What I did

  1. reinstall optional esbuild and rollup deps
  2. fix a rollup ts error (or more accurately, acknowledge that it was fixed upstream)

Testing Instructions

  1. fresh clone
  2. npm ci
  3. npm start

Notes to Reviewers

  1. try to test on mac, windows, and linux if possible
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1353a65ccb0449db0a329ff90e8f29506c7ece50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @patternfly/pfe-tools | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 1353a65ccb0449db0a329ff90e8f29506c7ece50
Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/66177123c706170008779e08
Deploy Preview https://deploy-preview-2736--patternfly-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bennypowers commented 2 months ago

no longer necessary