search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

feat!: ssr #2762

Closed bennypowers closed 1 week ago

bennypowers commented 1 month ago

What I did

  1. remove DOM side effects from core main module
  2. add ssr test helpers
  3. add ssr test demo files
  4. write some ssr tests

Testing Instructions

npx playwright test -g ssr --update-snapshots --max-failures=1000
npx playwright show-report test-results

Notes to Reviewers

  1. this should maybe be refactored to put everything in PfeDemoPage
  2. maybe we should containerize this to get uniform results
  3. The test results show exactly where components fail to SSR
  4. This PR does not need to get to 100% ssr success for every element, it's enough for now to just understand clearly where we fail
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 5a0c5d6bd63fe61e45d88999c5bd681a12e81da5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | -------------------- | ----- | | @patternfly/pfe-core | Major | | @patternfly/elements | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 279ae1f18fe72338610ba67a46de20a752cbaa8b
Deploy Preview https://deploy-preview-2762--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

bennypowers commented 1 month ago

I think we've gone as far with this as we can. The remaining failures are blocked by https://github.com/lit/lit/issues/3301

github-actions[bot] commented 1 month ago

SSR Test Report: Run attempt 1 on 4c717ac8cbc899a3a7b602da35c602f7397d7255

github-actions[bot] commented 1 month ago

SSR Test Run for f569011a47b3d5f849be2ac6b4f21306812d558d: Report

SSR Test Run for e17c44b0544e226ecdf7e270550e9a082b1a2249: Report

github-actions[bot] commented 1 month ago

SSR Test Run for 1987b2b46878b24545ae5b7c1aefc1aee018c450: Report

bennypowers commented 3 weeks ago