search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(accordion)!: remove BaseAccordion #2764

Closed bennypowers closed 1 week ago

bennypowers commented 1 month ago

Closes #2612

What I did

  1. remove accordion base classes
  2. combine css
  3. rename accordion event classes, adding Pf prefix

Testing Instructions

  1. compare DP to live, make sure everything's kosher

Notes to Reviewers

  1. we originally planned to write a controller, but that can come later. we should probably move a lot of the state into context props
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 4beb73ce78129b04b4203ffe402ddcfbd04d301f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | --------------------- | ----- | | @patternfly/pfe-tools | Minor | | @patternfly/elements | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 557db88dcb1165ad682d333af761ba097c2dbc6e
Deploy Preview https://deploy-preview-2764--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.