patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

fix(icon)!: remove getIconUrl for webpack's sake #2766

Closed bennypowers closed 1 week ago

bennypowers commented 3 weeks ago

What I did

  1. remove the getIconUrl static method
  2. add resolve static method
  3. change the signature of addIconSet static method
  4. Remove defaultIconSet static field

Testing Instructions

1.

Notes to Reviewers

1.

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 69b21282e0b2c5fe37aab955b5b78cdc63b73359

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/elements | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

zeroedin commented 3 weeks ago

Note for anyone reviewing. In order to bypass the jspm error, you can change the defaultProvider for the generator in /docs/_data/importMap.cjs to jsdelivr.

  const generator = new Generator({
    defaultProvider: 'jsdelivr',
    env: ['production', 'browser', 'module'],
  });

Doing so allowed me to test this branch.

github-actions[bot] commented 1 week ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 1dcbf92688974070acafc114de683410d59e4f7d
Deploy Preview https://deploy-preview-2766--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.