patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
375 stars 85 forks source link

feat(tools): knobs #2781

Open bennypowers opened 1 week ago

bennypowers commented 1 week ago

What I did

  1. add elements to tools
  2. add pft-element-knobs
  3. add knobs demos to dev server

Testing Instructions

  1. run the dev server
  2. http://localhost:8000/
  3. click on knobs

Notes to Reviewers

1.

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: dc7175ef5f538ac0fb4918d9caf08e62c6a57ccd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------- | ----- | | @patternfly/elements | Major | | @patternfly/pfe-core | Major | | @patternfly/pfe-tools | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 week ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit f6d3db3716a0360f3dd0f2f632b090ce580522b4
Deploy Preview https://deploy-preview-2781--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 1 week ago

SSR Test Run for ad7b36d4ff06149aa4045604317b4bbd079b908a: Report

github-actions[bot] commented 6 days ago

SSR Test Run for 80c0e664004c475bc2b3b4e493e23e9becc3e9f4: Report

github-actions[bot] commented 6 days ago

SSR Test Run for f6d3db3716a0360f3dd0f2f632b090ce580522b4: Report

zeroedin commented 5 days ago

@bennypowers this is great! Thinking about picking up pf-drawer to support this. My thinking is maybe the knobs could be out of the way on initial load then toggleable via a drawer. Thoughts?

bennypowers commented 5 days ago

There can be quite a lot of content, more than a side drawer

See text-input for example

Maybe a bottom panel

zeroedin commented 4 days ago

Maybe a bottom panel

Yeah I also noted the resizable drawer too which might be nice on certain viewport sizes.