fix(tools): correct dev server not serving lightdom.css files

zeroedin commented 3 days ago

What I did

Fix dev-server not serving lightdom.css files

Closes #2794

Testing Instructions

Follow instructions in #2794 ensure lightdom.css and lightdom-shim.css serve.
Launch dev server npm run serve

Notes to Reviewers

1.

changeset-bot[bot] commented 3 days ago

⚠️ No Changeset found

Latest commit: 3516d48954c50851c6a569fc48531327859dcdef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 3 days ago

Deploy Preview for patternfly-elements ready!

Name	Link
Latest commit	9011542b9d84fe90bf480cd01fae080be1b43f97
Deploy Preview	https://deploy-preview-2795--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

bennypowers commented 2 days ago

iirc there's a fix for this on staging/4.0.

Will check on Sunday

bennypowers commented 2 days ago

Thanks for filing this. I decided to put things in order a bit, so I

Removed some unused dependencies
Made pfe-tools deps into peerDeps
Refactored the dev server plugin to import it's middlewares from purpose-oriented modules
Split the router middlewares out into small, directed functions, one per case.
Improved the inline documentation for the router functions, hopefully clarifying what each middleware does

I then tested with these steps:

add /elements/accordion/pf-accordion-lightdom.css which sets background to blue
add /elements/accordion/pf-accordion-lightdom-shim.css which sets border to pink
add /elements/accordion/demo/components@2x.png copied from /brand
link to both stylesheets and the image from /elements/pf-accordion/demo/pf-accordion.html
link to both stylesheets and the image from /elements/pf-accordion/demo/bordered.html
build and run the dev server
ensure that in both the accordion and bordered demos, the css applies and the image loads
kill the dev server
copy (not npm link, but copy) the contents of tools/pfe-tools/dev-server to rhds repo's node_modules
replace the fully qualified urls in the avatar demos with local demos, and populate those images
run the dev server in the rhds directory
ensure that the avatar, avatar color context, table, and table color context demos render as expected

patternfly / patternfly-elements