patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
379 stars 96 forks source link

fix(core): improved ssr #2833

Closed bennypowers closed 3 months ago

bennypowers commented 3 months ago

What I did

  1. make dom shims it's own file, importable from downstream packages
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: a5bbdcd0c15e8d2d3c9c01a3772eeb5ca2d3ed7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago

✅ Commitlint tests passed!

More Info ```json { "valid": true, "errors": [], "warnings": [], "input": "fix(core): improved ssr" } ```
netlify[bot] commented 3 months ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit fd2b21df9d88f65913c3fa9570d91308a9880847
Deploy Preview https://deploy-preview-2833--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 3 months ago

SSR Test Run for fd2b21df9d88f65913c3fa9570d91308a9880847: Report