Closed zeroedin closed 2 months ago
Latest commit: ac185357697e7b718d04b896eae2e7a5e3e4826b
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 288f7b641523b0428307b8d93e8cf313f8f557ff |
Deploy Preview | https://deploy-preview-2855--patternfly-elements.netlify.app/ |
To edit notification comments on pull requests, go to your Netlify site settings.
@bennypowers adding await aTimeout(50);
allows the pf-tabs
tests to complete. That said I'm not convinced that just adding a timeout to the test is the correct way to handle red/green here. Another way to do it is await 3x nextFrame.
beforeEach(nextFrame);
beforeEach(nextFrame);
beforeEach(nextFrame);
beforeEach(updateComplete);
I can almost understand the need for nextFrame better here as we are now adding a tick given the overflow controller implementing the requestAnimationFrame
. Thoughts?
Downstream issue:
Documentation Reference
What I did
Testing Instructions
1.
Notes to Reviewers
1.