patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
379 stars 96 forks source link

fix(jump-links): landmark label #2870

Open bennypowers opened 1 month ago

bennypowers commented 1 month ago

Closes #2860

What I did

  1. add aria-labelledby="label" to the nav landmark element

Testing Instructions

  1. confirm that screen readers read the page correctly

Notes to Reviewers

  1. Note that the listbox is already labelled by the same element.
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: a8397ef3f1a85b9a2e5b70db9e3564f14f84fb92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/elements | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

✅ Commitlint tests passed!

More Info ```json { "valid": true, "errors": [], "warnings": [], "input": "fix(jump-links): landmark label" } ```
netlify[bot] commented 1 month ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 3a5d314ea48dbd57381a61a30959720ab605d1a4
Deploy Preview https://deploy-preview-2870--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 1 month ago

SSR Test Run for af81208a98631a198b0314a6eb865b7be76a4dd2: Report

github-actions[bot] commented 3 weeks ago

SSR Test Run for 9c8154f6b798625631b74ab64127f0facc48f257: Report

github-actions[bot] commented 3 weeks ago

SSR Test Run for 3a5d314ea48dbd57381a61a30959720ab605d1a4: Report