search

patternfly / patternfly-elements

PatternFly Elements. A set of community-created web components based on PatternFly design.
https://patternflyelements.org/
MIT License
379 stars 96 forks source link

fix(core): slotController isEmpty respects text nodes #2880

Open bennypowers opened 1 week ago

bennypowers commented 1 week ago

What I did

  1. make slotcontroller's hasContent/isEmpty consider text nodes

Testing Instructions

  1. patch contents into RHDS, and check that cards with text nodes in default slot but no wrapping element still display their contents

Notes to Reviewers

  1. see https://stackblitz.com/edit/stackblitz-starters-u2qbnw?file=index.html
changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: e5103c5830edccc7b77dde0a1602cc4ba8cc6f7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @patternfly/pfe-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 week ago

✅ Commitlint tests passed!

More Info ```json { "valid": true, "errors": [], "warnings": [], "input": "fix(core): slotController isEmpty respects text nodes" } ```
netlify[bot] commented 1 week ago

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit f220b8fccaea86aef8b1adf31ff9ae32774d21a2
Deploy Preview https://deploy-preview-2880--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 1 week ago

SSR Test Run for f220b8fccaea86aef8b1adf31ff9ae32774d21a2: Report