search

patternfly / patternfly-ng

The code for a set of Angular 6+ components for the PatternFly project. Note that the release/3.x branch supports Angular 4 and 5.
http://www.patternfly.org/patternfly-ng
MIT License
88 stars 55 forks source link

feat(copy-updates): align copy component impl with latest designs #444

Closed seanforyou23 closed 6 years ago

seanforyou23 commented 6 years ago

This PR updates the copy clipboard components to use the latest designs and interactions specified in core.

One outstanding issue that I'm not sure how to resolve is that the tooltip text for the copy buttons updates to "Copied" for a few seconds after firing the copy action, however this value isn't updated in the DOM until you move your cursor away from the copy button and then back over the top of it again. I'm using property bound [tooltip] syntax which I thought would handle this but doesn't seem to. Any idea how to solve this?

make widths configurable improve tests add tooltip for copy buttons specify tooltip container to fix tooltip flutter use input element for copy value container remove redundant triggers clean up view templates use obj for storing common values in copyBase use readonly input instead of span so copy value is scrollable use tooltipText input prop instead of tooltip to avoid namespace collision specify body for container attribute to fix tooltip styling issues avoid breaking changes by setting buttonAriaLabel to buttonLabel value when passed in update tests to use new property name

patternfly-build commented 6 years ago

Deploy preview for patternfly-ng ready!

Built with commit b640c9e63da3f11ec4332994b785d88e4c34b1ef

https://deploy-preview-444--patternfly-ng.netlify.com

patternfly-build commented 6 years ago

:tada: This PR is included in version 4.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: