search

patternfly / patternfly-ng

The code for a set of Angular 6+ components for the PatternFly project. Note that the release/3.x branch supports Angular 4 and 5.
http://www.patternfly.org/patternfly-ng
MIT License
88 stars 55 forks source link

onContextMenu event raises error on table component #456

Closed LarsLuz closed 5 years ago

LarsLuz commented 5 years ago

Hello, I've realized that an error is raised when you perform an right click on the table component.

You can actually reproduce this by visiting: https://www.patternfly.org/patternfly-ng/#/table and right clicking anywhere on the table. I am not sure if the error is only in the example (which I used as reference for my use of the component) or actually inside the library. I've tried to add (onTableContextMenu) on my tag, but the error is still raised and the event isn't triggered.

dlabrecq commented 5 years ago

Thank you for the info. This is an issue with the example.

I believe this was leftover from testing. That is, to test if the underlying data table events are passed thru properly.

There are no patterns/examples supporting context menus. Thus, handleOnTableContextMenu does not exist. The following line should be removed from table.component.html.

(tableContextmenu)="handleOnTableContextMenu($event)"

dlabrecq commented 5 years ago

Closing due to inactivity.