search

patternfly / patternfly-ng

The code for a set of Angular 6+ components for the PatternFly project. Note that the release/3.x branch supports Angular 4 and 5.
http://www.patternfly.org/patternfly-ng
MIT License
88 stars 55 forks source link

can i use patternfly With angular 7? #457

Closed AbdelrahmanSayedMohamed closed 5 years ago

LarsLuz commented 5 years ago

Yes, you can. It will complain about peerDependencies but it will work.

dlabrecq commented 5 years ago

PatternFly-ng is built with Angular 6 and Typescript 2.9.2, but it works with Angular 7. I have not tried it with Angular 8, but believe 8 supports Typescript 3.2, while Angular 7 supports 3.1?

mprahl commented 5 years ago

@dlabrecq is it on the roadmap to update patternfly-ng to not complain about peerDependencies?

dlabrecq commented 5 years ago

I created a PR to update the peer dependencies. https://github.com/patternfly/patternfly-ng/pull/462

A couple caveats, tho.

  1. PatternFly-ng is not compatible with the dropdown of ngx-bootstrap v3.3.0. Tested v3.0.0-v3.2.0 and they worked fine.

Screen Shot 2019-06-11 at 3 01 19 PM

  1. The following may also need to be added to the options of angular.json
"options": {
  "preserveSymlinks": true,

See: https://stackoverflow.com/questions/53833985/no-provider-for-viewcontainerref-while-using-ng-packagr-component