search

patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 136 forks source link

Bug - update Twitter references #4038

Open edonehoo opened 2 months ago

edonehoo commented 2 months ago

Since Twitter is now called X, we need to update references across the website to match X, including icons.

evwilkin commented 2 months ago

@andrew-ronaldson it looks like the x-twitter icon was added to fortawesome in 6.4.2 but react-icons is currently using version 5.15.4 which is why it's not showing up in our full icons list.

Next steps could be to either open a React issue to bump the fortawesome version, though it's going up a major version so not sure what additional implications that could have, or potentially copy the SVG code from the icon page and paste that code block in place of the <TwitterIcon> component

andrew-ronaldson commented 2 months ago

I tried pasting in the SVG code and it was unhappy with me. I'll try again.