search

patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 136 forks source link

Some react-icons have the wrong className #4047

Closed mcoker closed 2 months ago

mcoker commented 2 months ago

Looking at v6 staging on org, I noticed some of the icons are off-center in the <Label> component, and looks to be the result of some of them having .pf-v5-svg (incorrect) and others having .pf-v6-svg (correct).

Screenshot 2024-05-30 at 10 05 16 AM Screenshot 2024-05-30 at 10 05 06 AM
mcoker commented 2 months ago

cc @kmcfaul @nicolethoen

nicolethoen commented 2 months ago

I believe this is now resolved in a newer version of staging.