search

patternfly / patternfly-org

Home of patternfly.org
https://www.patternfly.org
MIT License
69 stars 135 forks source link

fix: clean up toc/JumpLinks styling #4083

Closed nicolethoen closed 6 days ago

nicolethoen commented 1 month ago

Closes: https://github.com/patternfly/patternfly-org/issues/4064

I cannot figure out how to get the mobile jumplinks/table of contents to scroll properly. I tried to do overflow-y: scroll on the .ws-toc.pf-m-expanded .pf-v6-c-jump-links__main but it is clipping the toggle arrow. Very open to suggestions.

patternfly-build commented 1 month ago

Preview: https://patternfly-org-pr-4083-site.surge.sh

mcoker commented 1 month ago

@nicolethoen the jump links toggle caret is getting cut off because of an odd, yet intentional style in jump links from v5. In reviewing the figma jump links designs, looks like that style was removed and the update to remove it in v6 was overlooked. Here's a core issue to fix https://github.com/patternfly/patternfly/issues/6797.