docs(typography): Updates content with tokens.

patternfly / patternfly-org

Home of patternfly.org

https://www.patternfly.org

MIT License

69 stars 135 forks source link

docs(typography): Updates content with tokens. #4117

Open edonehoo opened 1 week ago

edonehoo commented 1 week ago

Closes #4041

patternfly-build commented 1 week ago

Preview: https://patternfly-org-pr-4117-site.surge.sh

edonehoo commented 1 week ago

@andrew-ronaldson curious for your thoughts on the accuracy and especially the page design, because I changed from the current page structure & I'm not sure if its more/less helpful

andrew-ronaldson commented 1 week ago

I like the new structure you've created here. Couple of comments below: The ✅ Correct and ❌ Incorrect icons could use a space. I wonder if we should mention something in the body size table that we are converting the fonts to REMs there is a PR up now. We should update this screenshot to as the headers look like v5. Screenshot 2024-07-03 at 10 20 07 AM

edonehoo commented 4 days ago

@andrew-ronaldson I updated that image and added references to rems! lmk if anything is inaccurate. and @kaylachumley Nicole adjusted the overall spacing on org in a separate pr, so this one will inherit those changes and hopefully fix the tight spacing 🤞